• Mythri A's avatar
    [turboprop] Record handle to map in dynamic map checks operator · adfdccc0
    Mythri A authored
    Monomorphic loads are quite common and it is important to keep these
    load accesses fast. Dynamic map checks increases the overhead for these
    monomorphic accesses by having to actually verify the IC state and check
    against a map from the feedback vector This was causing a significant
    (~2-3%) regression in JavaScript duration. To keep the common case of
    monomorphic checks fast, we now want to add a check against expected
    map (which passes in most cases) and move the rest of the checks to a
    builtin. i.e. we want dynamic map checks (when generating the code for
    loads in monomorphic state) to look like:
    
    if (incoming_map != HeapConstant(expected_map))
      call_builtin;
    
    This helps us to keep the most common case fast and still gets the
    benefits of dynamic map checks.
    
    This cl is the first in the series of cls that will add this
    functionality. This cl makes the expected_map available for dynamic map
    checks operator. In follow up cls, we will add a builtin and update
    the code to use the builtin.
    
    
    Bug: v8:10582
    Change-Id: I10992c6ba1fb005592de962310c208cff6829119
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2397894Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69798}
    adfdccc0
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...