• Jakob Kummerow's avatar
    [test] Object verification should not recurse · ad8f2f6f
    Jakob Kummerow authored
    When running with --verify-heap, ObjectVerify() is invoked for every
    live object anyway, so there is no need for individual FooVerify()
    implementations to recursively request verification of their
    sub-objects. If they do, (a) it is duplicated work of O(n²) complexity,
    and (b) it can cause fuzzer-generated tests to crash because they run
    out of stack space when they trigger heap verification with very little
    stack space left.
    
    Fixed: chromium:1106426
    Change-Id: Ib9bd444806b148fffc23d635f931dfe73fe7e4ce
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358746
    Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69477}
    ad8f2f6f
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...