• jgruber's avatar
    [cctest] Fix invalid assumption in test-unboxed-doubles · ad75ded2
    jgruber authored
    test-unboxed-doubles/WriteBarrierObjectShiftFieldsRight recently started
    failing on arm64-nosnapshot builds due to a broken CHECK.
    
    # Fatal error in ../../test/cctest/test-unboxed-doubles.cc, line 1417
    # Check failed: heap->InNewSpace(*obj_value).
    
    It expects the result of Factory::NewJSArray() to be in new
    space; but NewJSArray encapsulates two allocations so the return value can
    actually be in old space. Fix it by ensuring only one allocation occurs.
    
    BUG=v8:5339
    
    Review-Url: https://codereview.chromium.org/2759433002
    Cr-Commit-Position: refs/heads/master@{#43886}
    ad75ded2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...