• Benedikt Meurer's avatar
    [wasm][debug] Expose instance and module instead of imports / exports. · ad42f966
    Benedikt Meurer authored
    The "imports" and "exports" that were exposed on WebAssembly frames via
    Debug-Evaluate aren't useful for the DWARF C/C++ extension (and likely
    not for any other language extension), since they only expose static
    information that's easily available (upfront) by reading the Wasm wire
    bytes.
    
    In fact, there are already standardized functions in the WebAssembly
    specification, namely `WebAssembly.Module.imports(module)` and
    `WebAssembly.Module.exports(module)`, which yield static information
    about the imports and exports of a Wasm module.
    
    So instead of exposing special, non-standard "imports" and "exports", we
    now instead expose both the "instance" and the "module" objects via both
    the Debug Proxy and the Scope view, and also add internal [[Exports]]
    and [[Imports]] properties to WasmModuleObject, which under the hood use
    the standard methods mentioned above.
    
    Fixed: chromium:1162069
    Bug: chromium:1071432, chromium:1083146
    Screenshot: https://imgur.com/lcaW2jL.png
    Doc: https://docs.google.com/document/d/1rqbu0jKTl3q_xCxLnKzkjGXWEsHnJ9aERVhKV9RNDgE#bookmark=id.925bb2qgou38
    Change-Id: Ie27e55bb08ea5f90493c57375bf2b48dfb11a4d2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606050
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71893}
    ad42f966
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...