• Benedikt Meurer's avatar
    [wasm][debug] Expose instance and module instead of imports / exports. · ad42f966
    Benedikt Meurer authored
    The "imports" and "exports" that were exposed on WebAssembly frames via
    Debug-Evaluate aren't useful for the DWARF C/C++ extension (and likely
    not for any other language extension), since they only expose static
    information that's easily available (upfront) by reading the Wasm wire
    bytes.
    
    In fact, there are already standardized functions in the WebAssembly
    specification, namely `WebAssembly.Module.imports(module)` and
    `WebAssembly.Module.exports(module)`, which yield static information
    about the imports and exports of a Wasm module.
    
    So instead of exposing special, non-standard "imports" and "exports", we
    now instead expose both the "instance" and the "module" objects via both
    the Debug Proxy and the Scope view, and also add internal [[Exports]]
    and [[Imports]] properties to WasmModuleObject, which under the hood use
    the standard methods mentioned above.
    
    Fixed: chromium:1162069
    Bug: chromium:1071432, chromium:1083146
    Screenshot: https://imgur.com/lcaW2jL.png
    Doc: https://docs.google.com/document/d/1rqbu0jKTl3q_xCxLnKzkjGXWEsHnJ9aERVhKV9RNDgE#bookmark=id.925bb2qgou38
    Change-Id: Ie27e55bb08ea5f90493c57375bf2b48dfb11a4d2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606050
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71893}
    ad42f966
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...