• ahaas's avatar
    [wasm] Refactor the non-determinism detection in the interpreter. · ac187c03
    ahaas authored
    Apparently it happens quite easily that different NaNs are produced in
    the interpreter than in the execution of the compiled code. This
    non-determinism caused problems for the fuzzer which compares the
    equality of the results of the interpreter and the compiled code.
    
    I decided therefore to refactor the detection of non-determinism in the
    interpreter. Instead of tracking whether potentially non-deterministic
    NaNs were produced, I track now whether potentially non-deterministic
    NaNs could have been observed. The only way the NaN non-determinism can
    be observed is by observing the non-deterministic bit pattern of the
    NaN. AFAICT the only way to observe the bit pattern is with a
    I(32|64)_REINTERPRET_F(32|64) instruction or with a F(32|64)_STORE
    followed by a load. Therefore I flag an execution as potentially
    non-deterministic when either a NaN is reinterpreted to an int, or when
    a NaN is stored to memory.
    
    R=titzer@chromium.org, eholk@chromium.org
    BUG=682180
    
    Review-Url: https://codereview.chromium.org/2671803002
    Cr-Commit-Position: refs/heads/master@{#42917}
    ac187c03
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...