• Leszek Swirski's avatar
    [liveedit] Use start position in function lookup · ac0c19b6
    Leszek Swirski authored
    Instead of looking up functions by their function literal id (which can
    be slow now that function id involves a linear search for compiled
    functions), we key the lookup by the function's start position.
    
    This means that the script+literal id swapping to find equivalent
    unchanged functions during constant pool patching no longer works -- we
    could replace it by fixing up the start position of the redundant new
    function, but instead we just build up a side-table mapping (new) start
    positions to function literal ids, and use that function literal id to
    find the old function in the script's SFI list.
    
    Change-Id: I10bfce6c39665cba063e0ddbc8fd38a6f5fd5513
    Reviewed-on: https://chromium-review.googlesource.com/1140169Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54542}
    ac0c19b6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...