• Clemens Backes's avatar
    Revert "[wasm] Prevent breakpoints on nonbreakable positions" · d1462a56
    Clemens Backes authored
    This reverts commit 3c98a2a3.
    
    Reason for revert: Fails on arm: https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/12134
    
    Original change's description:
    > [wasm] Prevent breakpoints on nonbreakable positions
    > 
    > If a breakpoint is set on a non-breakable position, the wasm interpreter
    > just stores the value 0xFF (kInternalBreakpoint) in the function body
    > (actually, a copy of the function body). This might overwrite immediates
    > and cause subsequent failures in the wasm interpreter.
    > 
    > In JavaScript, breakpoints are just forwarded to the next breakable
    > position. This CL implements the same for WebAssembly.
    > A cctest tests this behavior, and the existing
    > wasm-stepping-byte-offsets.js inspector test is extended to also set the
    > breakpoint within an i32 constant immediate.
    > 
    > R=​leese@chromium.org, mstarzinger@chromium.org
    > CC=​​bmeurer@chromium.org
    > 
    > Bug: chromium:1025184
    > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65070}
    
    TBR=mstarzinger@chromium.org,clemensb@chromium.org,bmeurer@chromium.org,leese@chromium.org
    
    Change-Id: I7468ea3b15fecccdea521308325cf4851e0a0396
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1025184
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926032Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65074}
    d1462a56
Name
Last commit
Last update
..
console Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
runtime Loading commit data...
runtime-call-stats Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
testcfg.py Loading commit data...