• Peter Marshall's avatar
    [typedarray] Fix IterableToList when Number has an iterator · aaa78c33
    Peter Marshall authored
    IterableToListCanBeElided checked that the input was always a HeapObject
    but this is not true when an iterator symbol is defined on the Number
    prototype, meaning Smi and HeapNumber can also be passed in.
    
    Added a regression test for the crash and some correctness tests for
    smi and double input to TA.from.
    
    Also factored out the tests in typedarray-from.js that modify global
    state e.g. protector cells, so that one iteration of the top level
    loop does not interfere with the next.
    
    Bug: chromium:814643
    Change-Id: I364d11f011faf8370446f905a35a945d47e4477f
    Reviewed-on: https://chromium-review.googlesource.com/930962Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51461}
    aaa78c33
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...