• Simon Zünd's avatar
    [debug] Fix scope for class member initializer · aa101ca1
    Simon Zünd authored
    This CL removes the bailout when trying to collect the scope info
    for the class member initializer function. While this might not have
    worked previously, now we only need to tweak the scope search
    slightly to fix this. Class member initializer functions never
    have their own context but instead us the class context. That means
    that most of the logic in debug-scopes.cc doesn't really matter and we
    only need to initialize the ScopeIterator properly with the class
    context and the member initializer JSFunction.
    
    Note that this still does not fully fix bug 1350842. That is because
    we still run into a DCHECk when paused at a `new class { ... }`
    statement. We'll fix that in a separate CL.
    
    R=bmeurer@chromium.org
    
    Bug: chromium:1350842
    Change-Id: Id128b10676a5aa8a77309735e755e485f2c14446
    Fixed: chromium:1246889
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3825881
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82387}
    aa101ca1
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...