• Simon Zünd's avatar
    [debug] Fix scope for class member initializer · aa101ca1
    Simon Zünd authored
    This CL removes the bailout when trying to collect the scope info
    for the class member initializer function. While this might not have
    worked previously, now we only need to tweak the scope search
    slightly to fix this. Class member initializer functions never
    have their own context but instead us the class context. That means
    that most of the logic in debug-scopes.cc doesn't really matter and we
    only need to initialize the ScopeIterator properly with the class
    context and the member initializer JSFunction.
    
    Note that this still does not fully fix bug 1350842. That is because
    we still run into a DCHECk when paused at a `new class { ... }`
    statement. We'll fix that in a separate CL.
    
    R=bmeurer@chromium.org
    
    Bug: chromium:1350842
    Change-Id: Id128b10676a5aa8a77309735e755e485f2c14446
    Fixed: chromium:1246889
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3825881
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82387}
    aa101ca1
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...