• Benedikt Meurer's avatar
    [v8-extras] Harden `resolvePromise()` and `rejectPromise()`. · aa00ee22
    Benedikt Meurer authored
    The V8 Extras API provides `resolvePromise()` and `rejectPromise()`
    functions that bypass the safety net of the resolve/reject closures
    that you get from using the Promise constructor. So it's the
    responsibility of the user to make sure that the promises are still
    pending. This adds release mode checking and hard aborts to make
    sure we catch misuse of these APIs early.
    
    This also turns the DCHECK's in the C++ implementation into actual
    CHECK's to make sure we crash hard if the invariants are violated.
    
    Bug: chromium:931949, chromium:931640
    Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
    Change-Id: I98a6f424d2a3cfbb608fed21036caff6e2510ec3
    Reviewed-on: https://chromium-review.googlesource.com/c/1472291Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59610}
    aa00ee22
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...