• Clemens Hammacher's avatar
    [test] Check for illegal uses of mjsunit methods · a9e93572
    Clemens Hammacher authored
    The assertThrows and assertDoesNotThrow methods expect either a
    function to execute, or a string to eval. In several tests however we
    accidentally passed the *result* of the statement to be tested instead
    of the code.
    This CL adds check to catch such error early, and removes wrong uses.
    In most places, we do not need to use assertDoesNotThrow anyway,
    because exceptions are handled as test failures.
    
    Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
    MjsUnitAssertionErrors correctly.
    
    R=mathias@chromium.org
    
    Bug: v8:8562
    Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
    Reviewed-on: https://chromium-review.googlesource.com/c/1439238Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59277}
    a9e93572
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...