• Benedikt Meurer's avatar
    [turbofan] Properly handle smis in monomorphic loads/stores. · a9da0ce7
    Benedikt Meurer authored
    When lowering a monomorphic load/store, where multiple receiver maps
    have been recorded, but the action to be performed is the same (i.e.
    yielding undefined because the property is not found), TurboFan used
    to ignore the Smi case, leading to a pretty terrible deoptimization
    loop, as the LOAD_IC/STORE_IC properly recorded that state and thus
    didn't change it's state.
    
    Fixing this issue gives a 18-20% boost on the prettier test of the
    web-tooling-benchmark, which was suffering a lot from this problem.
    
    Bug: v8:6936, v8:6991
    Change-Id: Id208ec7129a7f6b190d989bda31f936040393226
    Reviewed-on: https://chromium-review.googlesource.com/735342Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48865}
    a9da0ce7
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...