• Benedikt Meurer's avatar
    [inspector][stack-traces] Remove support for "displayName". · a9b6f3f7
    Benedikt Meurer authored
    As outlined in the design document linked below, we're removing the
    support for the non-standard Function.displayName property for the
    purpose of Error.stack and DevTools Inspector stack traces. The
    motivation here is that the negative lookup is costly, and we have
    Function.name as a standard alternative (configurable since ES6 for
    exactly this reason).
    
    I dediced to go with JSFunction::GetDebugName(), since
    JSFunction::GetName() was confusing in that it'd only get the "name"
    property's value if it's a data property, but not with accessors.
    JSFunction::GetDebugName() makes it clear that this is really a debug
    helper function and might not give you the "name" property value.
    
    Doc: https://bit.ly/devtools-function-displayName-removal
    Bug: v8:8742, chromium:1177685, chromium:1077657, chromium:17356
    Change-Id: I7717585cbace626174b2f2ed2a4f68f75429eca1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692189
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72715}
    a9b6f3f7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...