• Benedikt Meurer's avatar
    [inspector][stack-traces] Remove support for "displayName". · a9b6f3f7
    Benedikt Meurer authored
    As outlined in the design document linked below, we're removing the
    support for the non-standard Function.displayName property for the
    purpose of Error.stack and DevTools Inspector stack traces. The
    motivation here is that the negative lookup is costly, and we have
    Function.name as a standard alternative (configurable since ES6 for
    exactly this reason).
    
    I dediced to go with JSFunction::GetDebugName(), since
    JSFunction::GetName() was confusing in that it'd only get the "name"
    property's value if it's a data property, but not with accessors.
    JSFunction::GetDebugName() makes it clear that this is really a debug
    helper function and might not give you the "name" property value.
    
    Doc: https://bit.ly/devtools-function-displayName-removal
    Bug: v8:8742, chromium:1177685, chromium:1077657, chromium:17356
    Change-Id: I7717585cbace626174b2f2ed2a4f68f75429eca1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692189
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72715}
    a9b6f3f7
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...