• Nico Hartmann's avatar
    [turbofan] Make BigInt operations kNoThrow again · a99ca6e6
    Nico Hartmann authored
    A previous CL removed the kNoThrow flags from both
    SpeculativeBigIntAdd and SpeculativeBigIntSubtract. This introduced a
    bug, because the JSTypeHintLowering phase, where these operators are
    introduced during inlining, does not support the generation of throwing
    operators.
    
    Since these operators always deoptimize in case of an error, instead of
    throwing the exception directly, it is safe to mark them as kNoThrow.
    
    Bug: chromium:1091461
    No-Try: true
    No-Tree-Checks: true
    Change-Id: I551616b0c462647574e5af8824d9ed7b3252659d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235113
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68254}
    a99ca6e6
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...