• Jakob Gruber's avatar
    Remove FlagScope use in test-js-to-wasm.cc · a8a8e6b7
    Jakob Gruber authored
    Flag reads from background threads are unfortunately scattered and
    hard to completely avoid in the current state of V8. An example TSAN
    failure:
    
    ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN/36369/overview
    
    The root cause is that FlagScope destruction modifies flag values on
    the main thread, racing with flag reads from the background thread. In
    cctests, there's no need to reset flags back to initial values at the
    end of tests. Let's simply remove the problematic flag scopes.
    
    Bug: v8:11658
    Change-Id: I59ed3794ddc9ed570772726a423dc22afc4dc207
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2843346
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74082}
    a8a8e6b7
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...