• Clemens Hammacher's avatar
    [wasm] [interpreter] Tighten possible nondeterminism · a74ee933
    Clemens Hammacher authored
    The current implementation overapproximates the
    possible_nondeterminism_ bit by setting it whenever a NaN value is
    reinterpreted as integer, or stored to memory. This hides bugs in the
    interpreter that are handled as possible nondeterminism even though
    they are not.
    This CL fixes this by only setting the bit if a binary floating point
    operation is executed and one of the inputs is a NaN.
    
    R=ahaas@chromium.org
    
    Bug: v8:6954
    Change-Id: Ib937ae7730dbb140c012d07fae23b40ae7ed3d6b
    Reviewed-on: https://chromium-review.googlesource.com/735599
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48954}
    a74ee933
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...