• Jan Krems's avatar
    Allow quotes inside of embedded sourceMappingURLs · a73550bd
    Jan Krems authored
    The original implementation of matching was a RegExp on the source
    which wasn't able to reliably distinguish between comments inside
    of string literals and actual comments. For that reason, it had
    a special rule to disallow quotes to remove false positives.
    
    Original comment:
    > Also, ['"] are excluded from allowed URLs to  avoid matches
    > against sources that invoke evals with sourceURL.
    
    After the code was moved into the scanner, that shouldn't be an
    issue anymore - the scanner knows that this is a real comment and
    isn't part of a string literal.
    
    Allowing quotes enables a slightly smaller encoding of source maps,
    specifically in the case where there are no sourceContents:
    Non-base64 source maps can get away with effectively no encoding
    overhead (they typically don't contain whitespace).
    
    Change-Id: Iffa5df28d80656fa56e603e7c0e57aa1f44d0014
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576801Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Auto-Submit: Jan Krems <jankrems@google.com>
    Commit-Queue: Jan Krems <jankrems@google.com>
    Cr-Commit-Position: refs/heads/master@{#71742}
    a73550bd
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...