• Jan Krems's avatar
    Allow quotes inside of embedded sourceMappingURLs · a73550bd
    Jan Krems authored
    The original implementation of matching was a RegExp on the source
    which wasn't able to reliably distinguish between comments inside
    of string literals and actual comments. For that reason, it had
    a special rule to disallow quotes to remove false positives.
    
    Original comment:
    > Also, ['"] are excluded from allowed URLs to  avoid matches
    > against sources that invoke evals with sourceURL.
    
    After the code was moved into the scanner, that shouldn't be an
    issue anymore - the scanner knows that this is a real comment and
    isn't part of a string literal.
    
    Allowing quotes enables a slightly smaller encoding of source maps,
    specifically in the case where there are no sourceContents:
    Non-base64 source maps can get away with effectively no encoding
    overhead (they typically don't contain whitespace).
    
    Change-Id: Iffa5df28d80656fa56e603e7c0e57aa1f44d0014
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576801Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Auto-Submit: Jan Krems <jankrems@google.com>
    Commit-Queue: Jan Krems <jankrems@google.com>
    Cr-Commit-Position: refs/heads/master@{#71742}
    a73550bd
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...