• Santiago Aboy Solanes's avatar
    [object] Make the interaction [String::Get()-access guard] explicit · a6207b54
    Santiago Aboy Solanes authored
    We have recursive calls such ThinStrings where we go String::Get into
    ThinString::Get into String::Get again for the internalized string. If
    we need to, we would acquire the StringAccessGuard in the first
    String::Get and it wouldn't be needed to be re-acquired for the second
    String::Get. Trying to re-acquire it would in fact be an error since we
    are already holding the lock.
    
    The code, however, didn't know if we acquired it or not. It was working
    correctly due to the way the methods were defined and called. By passing
    down the access guard through the Get() calls we make this interaction
    explicit.
    
    Also add some thin string tests to test the interaction.
    
    Bug: v8:7790
    Change-Id: I1181edec1e802cb754c4d1d1ac268577257b92f3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936598
    Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74984}
    a6207b54
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...