• Dan Elphick's avatar
    Revert "[parsing] Improve elision of hole checks for default parameters" · a61ce8a0
    Dan Elphick authored
    This reverts commit e8d86597.
    
    Reason for revert: crbug.com/981701
    
    Original change's description:
    > [parsing] Improve elision of hole checks for default parameters
    > 
    > Use the position of the next parameter to be declared as the end of the
    > initializer for default parameters, so that hole checks can be elided
    > for initializers using previous parameters in arrow functions.
    > 
    > This fixes a source of bytecode mismatches when collecting source
    > positions lazily.
    > 
    > Bug: chromium:980422, v8:8510
    > Change-Id: I5ab074231248b661156e7d8e47c01685448b56d5
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1683267
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62525}
    
    TBR=verwaest@chromium.org,delphick@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:980422, v8:8510
    Change-Id: I3abd70a1fb00967e58b46177655a0078e24db720
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1697242Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62630}
    a61ce8a0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...