• Clemens Backes's avatar
    Reland "[wasm] Pass the script ID to code logging" · a58a5e59
    Clemens Backes authored
    This is a reland of ab4d9717.
    The original CL did a std::move before the final use of the NativeModule.
    PS2 removes that.
    
    TBR=petermarshall@chromium.org, thibaudm@chromium.org
    
    Original change's description:
    > [wasm] Pass the script ID to code logging
    >
    > We didn't pass a script ID with the code creation events for profiling.
    > This made DevTools lose the connection to the wasm script, hence
    > jumping from the profiler entry to the source did not work.
    >
    > This CL changes the timing of code logging a bit such that the script is
    > always allocated before logging. In the queue of code to be logged we
    > then also store the script ID, and finally set it on the {CodeEntry}
    > object.
    >
    > R=thibaudm@chromium.org
    >
    > Bug: chromium:1125986
    > Change-Id: I2248c1d520bc819436bbe732373f7a3446b64f48
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575057
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#71654}
    
    Bug: chromium:1125986
    Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng
    Change-Id: I2a7c5fe04fff726836b1279e3d05b1702a4efb76
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2578980Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71663}
    a58a5e59
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...