• Seth Brenith's avatar
    [cleanup][torque] Use @generateCppClass in some simple cases, part 2 · a5811358
    Seth Brenith authored
    This patch is mostly mechanical. A few changes in
    implementation-visitor.cc might be worth mentioning:
    - Don't generate both field offset macros and class definitions for the
      same class. This was mostly just to keep me from forgetting to remove
      the DEFINE_FIELD_OFFSET_CONSTANTS part when converting classes, but
      also helpfully flagged that FixedArrayBase wasn't using the generated
      class that it requested.
    - Generate forward declarations for all tq-defined classes in
      internal-class-definitions-tq.h. This is helpful for making things
      compile when classes have fields of other class types.
    - When generating accessors for union types, use the nearest class type
      that contains the entire union rather than plain Object. This is
      important for compile-time type safety. It also required a few minor
      fixes elsewhere (isolate.cc, modules.cc, scope-info.cc,
      source-text-module.cc, and a correction of the field types in
      CallHandlerInfo to match how they're set in api.cc).
    
    Change-Id: I3b9280e30779ce57fb9f3629eecfec898e26d708
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1774976Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#63458}
    a5811358
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...