• Simon Zünd's avatar
    Reland "[debug] Immediately step-in for 'stack check triggered' debug breaks" · a55ecfaf
    Simon Zünd authored
    This is a reland of commit 3297ccca
    
    This is a straight-up reland of the original CL. The failing test
    was flaky and removed with https://crrev.com/c/3868727. We replaced
    the test with a proper DevTools e2e test: https://crrev.com/c/3867522
    
    Original change's description:
    > [debug] Immediately step-in for 'stack check triggered' debug breaks
    >
    > This CL changes debug breaks that are triggered via interrupts (i.e.
    > via stack check). One client of this behavior is the `Debugger.pause`
    > CDP method.
    >
    > The problem is that when we pause so early, the JSFunction didn't have
    > time yet to create and push it's context. This requires special
    > handling in the ScopeIterator and makes an upcoming change unnecessary
    > complex.
    >
    > Another (minor) problem is that local debug-evaluate can't change
    > context-allocated local variables (see changed regression bug). Since
    > the context is not yet created and pushed, variables are written to
    > the DebugEvaluateContext that goes away after the evaluation.
    >
    > The solution is to mirror what `BreakOnNextFunction` does. Instead
    > of staying paused in the middle of the function entry, we trigger
    > a "step in" and pause at the first valid breakable position instead.
    > This ensures that the function context is already created and pushed.
    >
    > Note that we do this only in case for JSFunctions. In all other cases
    > we keep the existing behavior and stay paused in the entry.
    >
    > R=jgruber@chromium.org
    >
    > Fixed: chromium:1246907
    > Change-Id: I0cd8ae6e049a3b55bdd44858e769682a1ca47064
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854501
    > Reviewed-by: Jakob Linke <jgruber@chromium.org>
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82817}
    
    Change-Id: I1938ccb5979fd80dff530b2ffe3f18714b7eff3f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3867727
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82901}
    a55ecfaf
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...