• Jakob Gruber's avatar
    Revert "[torque] typed context slot access" · a55a2447
    Jakob Gruber authored
    This reverts commit 408e7240.
    
    Reason for revert: debug builds fail
    
    is_component_build = true
    is_debug = true
    use_goma = true
    v8_enable_backtrace = true
    v8_enable_debugging_features = true
    v8_enable_fast_mksnapshot = true
    v8_enable_slow_dchecks = true
    v8_enable_snapshot_code_comments = true
    v8_enable_verify_csa = true
    v8_optimized_debug = false
    v8_use_multi_snapshots = false
    
    # Fatal error in ../../src/compiler/backend/instruction-selector.cc, line 3088
    # Expected Turbofan static assert to hold, but got non-true input:
      static_assert(nativeContext == LoadNativeContext(context)) at src/builtins/promise-resolve.tq:45:5
    
    
    Original change's description:
    > [torque] typed context slot access
    > 
    > This introduces a new type Slot<ContextType, SlotType> that is used
    > for enum values used to access context slots.
    > Together with new types for the various custom contexts used in
    > Torque, this results in fairly type-safe access to context slots,
    > including the NativeContext's slots.
    > 
    > Drive-by changes:
    > - Introduce a new header file to specify headers needed for
    >   generated CSA headers, to reduce the amount of includes specified
    >   in implementation-visitor.cc
    > - Port AllocateSyntheticFunctionContext to Torque.
    > 
    > Bug: v8:7793
    > Change-Id: I509a128916ca408eeeb636a9bcc376b2cc868532
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335064
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#69249}
    
    TBR=tebbi@chromium.org,seth.brenith@microsoft.com
    
    Change-Id: I90c014022a808449aca4a9b9b3c3b8e036beb28e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7793
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2340903Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69256}
    a55a2447
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...