• Michael Stanton's avatar
    Revert "[ICs] Eliminate trampoline ICs in TurboFan generic lowering" · a52b4cdf
    Michael Stanton authored
    This reverts commit 7d699b93.
    
    Reason for revert: Actually we like the trampolines. Slight reduction in code size, and prevents spanning the icache.
    
    Original change's description:
    > [ICs] Eliminate trampoline ICs in TurboFan generic lowering
    > 
    > Trampoline ICs differ from normal ICs only in that they
    > load the feedback vector from the stack instead of accepting it
    > as an argument. We created them for FullCodeGen, where you always
    > have the feedback vector on the stack, and can reduce the amount
    > of code required to invoke an ICs by hiding the stack load down
    > in the trampoline IC.
    > 
    > Now the concept isn't really necessary, and we can achieve a
    > nice cleanup of our idea-space by removing it. The first step is
    > to remove their usage in TurboFan.
    > 
    > Bug: v8:7199
    > Change-Id: I08aefa5de199b1f19adea261b7086a84338c0805
    > Reviewed-on: https://chromium-review.googlesource.com/822193
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#50038}
    
    TBR=mvstanton@chromium.org,tebbi@chromium.org
    
    Change-Id: I63dcd98b799739d1d6ea55508b1ea5cfad9e3292
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7199
    Reviewed-on: https://chromium-review.googlesource.com/822420Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50063}
    a52b4cdf
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...