• Thibaud Michaud's avatar
    [wasm][liftoff] Fix spill offsets in merge regions · a4252db3
    Thibaud Michaud authored
    Recompute the spill offsets for values in the merge region, instead of
    reusing the offsets of the source. This ensures that spill slots stay
    contiguous (modulo alignment).
    This also solves a correctness issue where the spill offsets in the
    merge region could move up, thereby overwriting the source of another
    move.
    With this change, the spill offsets always move down (to fill the gap)
    or stay the same, such that processing them from bottom to top
    can only overwrite sources of already-processed moves.
    
    Since we do not reuse the current state's offsets, this might generate
    extra stack moves and regress generated code performance a bit.
    
    Drive-by: print spill offsets in the Liftoff trace
    
    R=clemensb@chromium.org
    
    Bug: v8:12270
    Change-Id: I8d20df8fc1e80dd36b6f651de457686e9935a628
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245115
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77556}
    a4252db3
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
security Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...