• zhengxing.li's avatar
    X87: [TurboFan] Change the implementation of Float32's NaN comparision's... · a337d159
    zhengxing.li authored
    X87: [TurboFan] Change the implementation of Float32's NaN comparision's return value in kX87Float32Min and kX87Float32Max.
    
      The CL 32796(https://codereview.chromium.org/1512023002) adds many Float32 comparision test data which including the NaN comparision.
    
      As there's no Specification for the return value of NaN comparision, Current x87 will check the Float comparision instruction's first
      operand, if it's NaN, return the second operand. Otherwise, return itself.
    
      But this conflicts with the Gcc compiler's implementation and cause the RunFloat32MinP and RunFloat32MaxP tests failed.
    
      For (a < b) comparision, The Gcc compiler will treat the NaN comparision's result same as a GT b and return b.
      The minss sse instruction in IA32 has the similar behavior.
    
      So this CL will make the implementation of NaN comparision's return value in kX87Float32Min and kX87Float32Max same as Gcc and IA32.
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1522333002
    
    Cr-Commit-Position: refs/heads/master@{#32866}
    a337d159
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...