• Clemens Hammacher's avatar
    [wasm] Dehandlify WasmCompiledModule interface · a1fcd777
    Clemens Hammacher authored
    The interface of {WasmCompiledModule} currently mostly receives and
    provides handles to the contained data. Other interfaces don't (see
    {object-macros.h}.
    This leads to performance and memory overhead for chained accesses like
    {instance->compiled_module()->shared()->script()}, because intermediate
    accessors allocate Handles for no reason. It also breaks the
    constraints that lower-case accessors should be trivial to execute, but
    allocating a handle is not trivial (should not be done in a loop if not
    needed).
    It also silences gcmole errors, as documented in
    https://crrev.com/c/832268.
    
    R=ahaas@chromium.org, mtrofin@chromium.org
    
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: Ib82fb295977a47b4a8ab9bae9c9b6e2b235ad5e5
    Reviewed-on: https://chromium-review.googlesource.com/832387
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50173}
    a1fcd777
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...