• Clemens Hammacher's avatar
    [wasm] [decoder] Fix incorrect use of VALIDATE macro · a0cde811
    Clemens Hammacher authored
    The VALIDATE macro should only be used for tests that do not have any
    side effect, because the side effect will only be executed if
    validation is active or in debug builds (because the condition is
    DCHECKed there).
    The TypeCheckBreak method has side effects since a while, since it
    inserts unreachable values on the stack.
    This did not lead to failures so far, since we only have validating
    users of the WasmFullDecoder. This will change once we have general
    lazy compilation of wasm modules, e.g. for tier-up.
    
    R=titzer@chromium.org
    
    Change-Id: I7b34dfd9297122616fa9ebdf899d9f44ca60273b
    Reviewed-on: https://chromium-review.googlesource.com/715416
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48490}
    a0cde811
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...