• Camillo Bruni's avatar
    [flags] Skip --random-seed in FlagList::Hash · 9fe53c4f
    Camillo Bruni authored
    Node and friends use --random-seed to temporary reset the seed for
    predictable code-cache creation. To allow custom random seeds at runtime
    the flag is reset for encoding the FlagList::Hash in the snapshots.
    
    We will soon disallow changing flags via the API after V8 has been
    initialized. In order to make node work we will exclude --random-seed
    from the FlagList::Hash calculation.
    
    Drive-by-fix:
    * Lazily initialize flag_hash instead of calculating it after every call
      to SetFlagsFromString / EnforceFlagImplications.
    * Simplify hash string source creation since out << flag now includes
      the full flag information
    
    Bug: v8:12309
    Change-Id: I1a168f4702d8c4d160ff12fdbea881731e4ea8b6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218159Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77345}
    9fe53c4f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...