• bmeurer's avatar
    [builtins] Don't canonicalize results of Math double operations. · 9f4f582b
    bmeurer authored
    For Math builtins that likely yield double results, i.e. Math.sin,
    Math.cos and friends, don't bother trying to canonicalize the result
    to Smi. The rationale behind this is that other parts of V8 use the
    HeapNumber representation as a hint to assume that certain values
    should be represented as double (i.e. for the array elements kind
    and for double field tracking). This way the chance that we make
    the ideal decision early on is better.
    
    For Math.abs we establish the contract that if the input value is a
    Smi, then we try hard to return a Smi (doesn't work for minimal Smi
    value), otherwise we preserve the HeapNumberness of the input.
    
    Same for the generic Add, Subtract, Multiply, etc. code stubs.
    
    R=yangguo@chromium.org
    
    Review-Url: https://codereview.chromium.org/2451973003
    Cr-Commit-Position: refs/heads/master@{#40573}
    9f4f582b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...