• Dominik Inführ's avatar
    [heap] Possibly finalize marking in Heap::ReportExternalMemoryPressure · 9dc5cd08
    Dominik Inführ authored
    We used to treat Heap::ReportExternalMemoryPressure just like
    allocation observer marking steps. Which means that we advance
    incremental marking but never finalize here immediately. This is
    now problematic without a separate COMPLETE phase when we don't reach
    the stack guard because we are stuck in C++ for awhile. In such cases
    we might perform way more marking work than we used to.
    
    We can fix this by finalizing marking immediately at this point when
    the stack guard was already armed. Otherwise we prefer to finalize
    marking in a task where we don't have a stack at all.
    
    For this we add a new method
    IncrementalMarking::AdvanceAndFinalizeIfNecessary. AdvanceFromTask
    is renamed to AdvanceAndFinalizeIfComplete to make the difference
    between those methods more clear.
    
    Bug: v8:12775, chromium:1354911
    Change-Id: If57bedb1a5f87923ccb8ad3fe2b60952e3843975
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3845082
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82626}
    9dc5cd08
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...