• Dominik Inführ's avatar
    [heap] Possibly finalize marking in Heap::ReportExternalMemoryPressure · 9dc5cd08
    Dominik Inführ authored
    We used to treat Heap::ReportExternalMemoryPressure just like
    allocation observer marking steps. Which means that we advance
    incremental marking but never finalize here immediately. This is
    now problematic without a separate COMPLETE phase when we don't reach
    the stack guard because we are stuck in C++ for awhile. In such cases
    we might perform way more marking work than we used to.
    
    We can fix this by finalizing marking immediately at this point when
    the stack guard was already armed. Otherwise we prefer to finalize
    marking in a task where we don't have a stack at all.
    
    For this we add a new method
    IncrementalMarking::AdvanceAndFinalizeIfNecessary. AdvanceFromTask
    is renamed to AdvanceAndFinalizeIfComplete to make the difference
    between those methods more clear.
    
    Bug: v8:12775, chromium:1354911
    Change-Id: If57bedb1a5f87923ccb8ad3fe2b60952e3843975
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3845082
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82626}
    9dc5cd08
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...