• Jakob Kummerow's avatar
    [bigint] Fix NoSideEffectsToString for 32-bit platforms · 9d493179
    Jakob Kummerow authored
    On 32-bit platforms, String::kMaxLength is such that not all BigInts
    can be converted to Strings. NoSideEffectsToString, however, used to
    assume that this conversion always succeeds. This patch adds a check
    for the failure case, and returns "<a very large BigInt>" instead of
    crashing.
    This change is practically unobservable, because actually formatting
    such a huge BigInt to String would take "forever", which is also why
    there is no regression test.
    
    Bug: chromium:876628
    Change-Id: I1eacdc1cce753ac5d9ca66e61e479043ab576e07
    Reviewed-on: https://chromium-review.googlesource.com/1194004Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55491}
    9d493179
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...