• Leszek Swirski's avatar
    [scopes] Skip dynamic vars in eval scopes during lookup · 9cf089e9
    Leszek Swirski authored
    For variable proxies in a function inside an eval scope that point to
    a dynamic variable in the eval scope, the current scope resolution will
    find this variable only when the function is eagerly compiled, as the
    eval scope only exists during top-level eval compilation. This causes
    a mismatch between lazy- and eager- compiled functions.
    
    With this patch, we skip these dynamic variables during lookup, so that
    the lookup for the variable proxy always finds a kDynamicLocal or
    kDynamicGlobal, both when compiled lazily and eagerly. This is a minor
    pessimisation of performance (as we know that the lookup has to be
    dynamic), but unblocks other improvements which require idempotent
    bytecode generation (such as lazy source positions).
    
    Note that the alternative, of simply not tracking dynamic variables on
    the eval scope at all, is not viable due to needing this information
    during conflict detection.
    
    Bug: v8:8510
    Bug: v8:9511
    Change-Id: Ifa72ec05e9a97b7be418912340081b9656765fd4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733077
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63051}
    9cf089e9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...