• bakkot's avatar
    Sloppy-mode function declarations in blocks are now hoisted appropriately. · 9bbba144
    bakkot authored
    In ES2016, function declarations nested in blocks are formally allowed. This was
    never a part of ECMAScript, but was a common extension. Unfortunately
    implementations differed in the exact semantics. Annex B.3.3 in the spec tries
    to standardize the parts which are common to different implementations, but does
    so with some fairly complicated semantics.
    
    This CL addresses three issues related to annex B.3.3:
    * When the outer function had a complex parameter list, no hoisting whatsoever was
      being performed.
    * Hoisting was not blocked by parameters of the same name.
    * Hoisting was not blocked by nested lexical declarations of the same name.
    
    We had tests which checked for the second, but they were incorrectly passing due to
    the first. This CL adds more complete tests.
    
    BUG=v8:5151, v8:5111
    
    Review-Url: https://codereview.chromium.org/2099623003
    Cr-Commit-Position: refs/heads/master@{#37405}
    9bbba144
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
fuzzer Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
ignition.gyp Loading commit data...
ignition.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...