• bakkot's avatar
    Sloppy-mode function declarations in blocks are now hoisted appropriately. · 9bbba144
    bakkot authored
    In ES2016, function declarations nested in blocks are formally allowed. This was
    never a part of ECMAScript, but was a common extension. Unfortunately
    implementations differed in the exact semantics. Annex B.3.3 in the spec tries
    to standardize the parts which are common to different implementations, but does
    so with some fairly complicated semantics.
    
    This CL addresses three issues related to annex B.3.3:
    * When the outer function had a complex parameter list, no hoisting whatsoever was
      being performed.
    * Hoisting was not blocked by parameters of the same name.
    * Hoisting was not blocked by nested lexical declarations of the same name.
    
    We had tests which checked for the second, but they were incorrectly passing due to
    the first. This CL adds more complete tests.
    
    BUG=v8:5151, v8:5111
    
    Review-Url: https://codereview.chromium.org/2099623003
    Cr-Commit-Position: refs/heads/master@{#37405}
    9bbba144
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...