• Ng Zhi An's avatar
    Reland "[wasm-simd][arm] Use vmov to move all ones to register" · 9b9c6b0e
    Ng Zhi An authored
    This is a reland of 57242a05
    
    no-sse4.1 builds were failing due to missing simd-scalar-lowering
    for s128.const, this reland adds that implementation.
    
    Original change's description:
    > [wasm-simd][arm] Use vmov to move all ones to register
    >
    > vceq(dst, dst, dst) does not seem to always set the register to all
    > ones. The right way should be be to use vmov (immediate) anyway. This
    > was not supported in the assembler yet, so we need changes to the
    > assembler, diassembler, and simulator.
    >
    > There is an unfortunate fork in logic in the simulator, due to the way
    > the switches are set up, vmov (imm) logic is duplicated across two
    > different cases, because the switch looks at the top bit of the
    > immediate. Refactoring this will be a bigger change that is irrelevant
    > for this bug, so I'm putting that off for now. Instead we extract the
    > core of vmov (imm) into helpers and call it in the two cases.
    >
    > Bug: chromium:1112124
    > Change-Id: I283dbcd86cb0572e5ee720835f897b51fae96701
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2337503
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Reviewed-by: Bill Budge <bbudge@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69315}
    
    Bug: chromium:1112124
    Change-Id: Id450e5cea41f7a569e49be8386a7788ca8f00658
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2346937Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69346}
    9b9c6b0e
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...