• Iain Ireland's avatar
    [regexp] Cache min/max-match for RegExpCapture/Group · 9b5141ca
    Iain Ireland authored
    Unlike the other RegExpTree types, RegExpCapture and RegExpGroup don't
    cache their min/maxMatch value. Instead, they compute it by recursing
    on the min/maxMatch of the body node. In pathological cases, with
    sufficiently small stacks, this can cause stack overflow. (In
    SpiderMonkey's case, it was a worker on 32-bit x86.)
    
    It's easy enough to just precompute the value when the body is set.
    
    R=jgruber@chromium.org
    
    Bug: v8:10303
    Change-Id: I4ba3d301d9a4a3f3c0cb94966148b747a4092d26
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2090192
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66673}
    9b5141ca
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...