• Simon Zünd's avatar
    [torque] Better SourcePositions for declarables · 9b30bdb4
    Simon Zünd authored
    This CL improves SourcePosition support inside the Torque compiler.
    It starts with the parser, where the SourcePosition of the
    MatchedInput now encompasses all tokens, not just the first one.
    
    Second, AST nodes can now be created with an explicit source position.
    This can be used to forward the "all encompassing" source position
    via MatchedInput -> ParseResultIterator to AST nodes.
    
    Third, declarables are extended to hold two different SourcePositions:
      - One represents the whole declarable. For a macro this would
        inlcude the body as well as the signature.
      - The other is the SourcePosition of the identifying part of a
        declarable. In most cases this is the name. For the rest this
        will stay invalid.
    
    R=sigurds@chromium.org, tebbi@chromium.org
    
    Bug: v8:7793
    Change-Id: I509f83aeef7a040d0ea6363b5b7c31ff1b11f47b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591600
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61234}
    9b30bdb4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...