• Zhi An Ng's avatar
    Revert "[code] Separate instruction and metadata areas" · 9a02964a
    Zhi An Ng authored
    This reverts commit b66993bc.
    
    Reason for revert: Broke v8 win32 https://ci.chromium.org/p/v8/builders/ci/V8%20Win32/29454?
    
    Original change's description:
    > [code] Separate instruction and metadata areas
    >
    > In this CL, Code object layout changes s.t. the instruction
    > area is distinct / non-overlapping from the metadata area.
    >
    > On-heap Code objects now have a variable-size `body` area,
    > containing distinct-but-adjacent `instruction` and `metadata`
    > areas.
    >
    > Off-heap code (= embedded builtins) currently have the same,
    > but in the future the metadata area will move elsewhere and
    > no longer be adjacent to instructions.
    >
    > To implement this, the main changes are:
    >
    >  - The Code object header now contains instruction and metadata
    >    sizes, and no longer contains the safepoint table offset
    >    (it's implicitly the first table of the metadata section).
    >  - The embedded metadata table contains information about both
    >    instruction and metadata areas.
    >
    > I've also added assertions in spots that currently rely on a
    > contiguous body area.
    >
    > Bug: v8:11036
    > Change-Id: I940f0c70c07ad511dafd2d2c3e337de8c92cd4b9
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2491025
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70743}
    
    TBR=jgruber@chromium.org,leszeks@chromium.org,clemensb@chromium.org,dinfuehr@chromium.org
    
    Change-Id: Ia52ac609a47b8a2038a2511f0af8526ebdfe4719
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:11036
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497381Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70744}
    9a02964a
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...