• Benedikt Meurer's avatar
    [cleanup] Harden the SubString CSA/Runtime implementations. · 99cb4d35
    Benedikt Meurer authored
    Remove the self-healing for invalid parameters in the
    CodeStubAssembler::SubString helper and the %SubString runtime function,
    which is used as a fallback for the CodeStubAssembler implementation.
    All call sites must do appropriate parameter validation anyways now that
    the self-hosted JavaScript builtins using these helpers are gone, and we
    have proper contracts with the uses.
    
    Also remove the context parameter from the CodeStubAssembler::SubString
    method, which is unnecessary, since this can no longer throw an
    exception.
    
    Bug: v8:5269, v8:6936, v8:7109, v8:7137
    Change-Id: I19d93bad5f41faa0561c4561a48f78fcba99a549
    Reviewed-on: https://chromium-review.googlesource.com/795720Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49702}
    99cb4d35
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...