• Qifan Pan's avatar
    Reland "[turbofan] Rematerialize BigInt64 in deopt" · 98c6c367
    Qifan Pan authored
    This is a reland of commit 80fb2815
    
    This CL fixes the signedness of rematerialized Numbers from immediates, which was introduced by the original change. Besides, BigInt truncation to zero bits is lowered to Int64Constant instead of NumberConstant of zero, which will flow into the state values directly.
    
    Original change's description:
    > [turbofan] Rematerialize BigInt64 in deopt
    >
    > This CL introduces two MachineTypes - SignedBigInt64 and UnsignedBigInt64, which are represented as Word64 but will be rematerialized to BigInt in deoptimization. This will avoid unnecessary conversions for BigInt64s when they are passed to StateValues.
    >
    > Bug: v8:9407
    > Change-Id: I65fdee3e028ed8f9920b1c20ff78993c7784de48
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858238
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Commit-Queue: Qifan Pan <panq@google.com>
    > Cr-Commit-Position: refs/heads/main@{#83230}
    
    Bug: v8:9407, chromium:1364319, chromium:1364400
    Change-Id: I0b4e077b52f64af46018b6c045893bbd56153f32
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899258
    Commit-Queue: Qifan Pan <panq@google.com>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83384}
    98c6c367
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...