• peterwmwong's avatar
    [builtins] Add Array.p.join fastpath for single element array. · 986aa36b
    peterwmwong authored
    This is resurrecting an optimization from the pre-torque version.
    Avoid allocating another sequential string for the result when there's only one
    element, just return the ToString-ed element.  This not only saves time writing
    to this destination string, but also reduce GC pressure.
    
    The System Health Memory Benchmark (load:media:google_images) exposed this missing
    optimization with a 15% regression in memory usage.  Very large external strings
    were being copied into V8's heap as sequential string.
    
    Bug: chromium:896612
    Change-Id: Ieb61906f64100cdc15bf96f3ebcccb1207f75356
    Reviewed-on: https://chromium-review.googlesource.com/c/1316620Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#57241}
    986aa36b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...