• Mythri A's avatar
    Hold on to FeedbackMetadata when allocating feedback vectors · 97ae1010
    Mythri A authored
    Allocating a new feedback vector happens in two steps: We create an
    empty structure and then initialize the array based on the
    FeedbackMetadata.When allocating a new feedback array we could trigger
    a GC which might flush the bytecode and associated feedback metadata.
    This shouldn't happen in normal cases, because we either allocate
    feedback vector after compilation or when we reach the expected budget.
    In both cases, the age of the feedback vector should be 0 and hence
    bytecode shouldn't be flushed. However, with debugger enabled we may
    allocate feedback vectors even when the bytecode array is old
    for example: when we enable precise invocation counters. This also
    causes issues in tests with --stress-flush-bytecode. In the stress mode
    we flush bytecode without considering the age. Holding on to the
    feedback metadata prevents crashes in such cases.
    
    Bug: v8:10560
    Change-Id: Ie806ff4102cb5fcf257c8683d5ca957853e38c05
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218066
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Auto-Submit: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68052}
    97ae1010
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...