• Paolo Severini's avatar
    Fix build error on ARM64/Windows · 97562879
    Paolo Severini authored
    In file include/v8config.h we define:
    
    ifdef V8_OS_WIN
    ...
    if defined(_M_X64) || defined(__x86_64__)
      define V8_OS_WIN_X64 true
    endif
    
    and V8_OS_WIN_X64 is supposed to be defined when targeting X64 on Windows only.
    But this is wrong because V8_OS_WIN_X64 gets defined also on an ARM64 builds
    when the host machine is X64. It should instead be:
    
    ifdef V8_OS_WIN
    ...
    if defined(V8_TARGET_ARCH_X64)
      define V8_OS_WIN_X64 true
    endif
    
    Bug: v8:9090
    Change-Id: I88e4c46bb6df1efa2070d4e1785081d71df96f0e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554222Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Paolo Severini <paolosev@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#60758}
    97562879
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...