• Sigurd Schneider's avatar
    Reland "[exceptions] Don't re-request interrupt in InvokeWithTryCatch" · b9df6e1c
    Sigurd Schneider authored
    This is a reland of 4ed9d48f
    
    CompileRun leads to undefined behavior if the compile fails;
    CompileRunChecked can be used to assert that the compile must
    succeed. I've removed the attempt to compile and rely on a
    simpler check in the tests now.
    
    Original change's description:
    > [exceptions] Don't re-request interrupt in InvokeWithTryCatch
    >
    > This CL changes InvokeWithTryCatch to not re-request the terminate
    > execution interrupt, but instead schedule the termination exception.
    > This ensures that leaving the outermost TryCatch scope will clear
    > the exception, and no interrupt remains.
    >
    > Previously, the interrupt request could remain and prevent further
    > JavaScript execution even after the TryCatch scope was left.
    >
    > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039
    > Bug: chromium:1014415
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65255}
    
    Tbr: yangguo@chromium.org, verwaest@chromium.org
    Bug: chromium:1014415
    Change-Id: I29444c4b7ea5a158865f54d4608f374914f7b133
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943151Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65258}
    b9df6e1c
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...